feat: properly parse and resolve tuples#3018
Open
JairusSW wants to merge 13 commits intoAssemblyScript:mainfrom
Open
feat: properly parse and resolve tuples#3018JairusSW wants to merge 13 commits intoAssemblyScript:mainfrom
JairusSW wants to merge 13 commits intoAssemblyScript:mainfrom
Conversation
it's not ready yet
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This PR adds basic support for the Tuples. Roadmap wise, this, along with a few more PRs, will pave the way for the Multi Value Proposal to be properly implemented.
The goal of this PR is not to add full-fledged support for
Tuples. Instead, it supports the basic functionality for parsing and resolving them since optimalTupleimplementation relies on Multi Value support.The order of the PRs to implement are:
binaryenmulti-valueby defaultSpeaking of that, all the features here hide behind
--enable multi-valueSo far, this implements:
Parser
function foo(x: [i32, i32]) {}function foo(): [i32, i32] {}return [0, 1]type Foo = [i32, i32][x: f64, y: f64]Compiler
not implemented(for now)I've read the contributing guidelines
I've added my name and email to the NOTICE file