Skip to content

Add support for HS256 ODIC#6110

Open
MilnerMart wants to merge 2 commits intoBookStackApp:developmentfrom
MilnerMart:development
Open

Add support for HS256 ODIC#6110
MilnerMart wants to merge 2 commits intoBookStackApp:developmentfrom
MilnerMart:development

Conversation

@MilnerMart
Copy link
Copy Markdown

Summary

This pull request adds the ability to accept other token signing algorithms, especially HS256, but with the possibility of extending to other algorithms as needed.

Checklist

  • I have read the BookStack community rules.
  • This PR does not feature significant use of LLM/AI generation as per the community rules above.

@ssddanbrown
Copy link
Copy Markdown
Member

Thanks for offering this @MilnerMart, but there's already an existing request to support addition signing options in #5912. This is blocked though as I feel we need to define where our bounds of support lie as my comment in #5390 (comment).
Feel free to provide input on #5390 in regard to the draft criteria, or even open a feature request issue to specifically request HS256 support.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Development

Successfully merging this pull request may close these issues.

2 participants