Skip to content

Migrate developer script to list-apps-in-pkg cmd#258666

Open
danielbayley wants to merge 2 commits intoHomebrew:mainfrom
danielbayley:list-apps-in-pkg
Open

Migrate developer script to list-apps-in-pkg cmd#258666
danielbayley wants to merge 2 commits intoHomebrew:mainfrom
danielbayley:list-apps-in-pkg

Conversation

@danielbayley
Copy link
Copy Markdown
Contributor

@danielbayley danielbayley commented Apr 10, 2026

Part of #174192.

  • list_apps_in_pkg

Script refactored, and now more reliably finds app sources from the pkg archive.


After making any changes to a cask, existing or new, verify:

Additionally, if adding a new cask:

  • Named the cask according to the token reference.
  • Checked the cask was not already refused (add your cask's name to the end of the search field).
  • brew audit --cask --new <cask> worked successfully.
  • HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask> worked successfully.
  • brew uninstall --cask <cask> worked successfully.

  • AI was used to generate or assist with generating this PR. Please specify below how you used AI to help you, and what steps you have taken to manually verify the changes, including zap stanza paths.

@bevanjkay
Copy link
Copy Markdown
Member

bevanjkay commented Apr 11, 2026

Thanks for opening these command migrations @danielbayley

Because there are so many PRs that you have opened at once, I'm asking this question here but it does relate to a few of the open PRs..

For maintainability, have you considered combining the list-*-in-pkg commands into a single command with variables? I guess there are pros and cons, but I had mentioned it in the issue that you referenced.

I think it could also be worth discussing whether some of these commands should/could move into Ruby commands, because then we have better style, typing and linting checks available.

@danielbayley
Copy link
Copy Markdown
Contributor Author

For maintainability, have you considered combining the list-*-in-pkg commands into a single command with variables? I guess there are pros and cons, but I had mentioned it in the issue that you referenced.

Possibly, what kind of API do you envisage for that? @bevanjkay

I think it could also be worth discussing whether some of these commands should/could move into Ruby commands, because then we have better style, typing and linting checks available.

Refactored many of them, most are ready for review…

cc: @Bo98

@danielbayley danielbayley force-pushed the list-apps-in-pkg branch 20 times, most recently from 66c4bf0 to 12c9461 Compare April 16, 2026 10:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants