git-credential-manager add linux support#259989
git-credential-manager add linux support#259989readefries wants to merge 1 commit intoHomebrew:mainfrom
Conversation
readefries
force-pushed
the
feat/add-linux-support-to-cask
branch
from
316ae1b to
edcff68
Compare
bevanjkay
left a comment
bevanjkay
left a comment
There was a problem hiding this comment.
Thanks @readefries
You will need to run brew style --fix git-credential-manager.
khipp
force-pushed
the
feat/add-linux-support-to-cask
branch
from
c4d6f0f to
b30eef0
Compare
| artifact "libHarfBuzzSharp.so", target: "#{HOMEBREW_PREFIX}/lib/libHarfBuzzSharp.so" | ||
| artifact "libSkiaSharp.so", target: "#{HOMEBREW_PREFIX}/lib/libSkiaSharp.so" | ||
| end |
There was a problem hiding this comment.
Does this mean it conflicts with the formula? Would it work if we depend on those instead?
There was a problem hiding this comment.
Not sure what you mean here. Which Formula do you mean here? Those shared objects are generated by the GCM build and packaged in the tarball.
There was a problem hiding this comment.
Isn't harfbuzz an artifact of https://formulae.brew.sh/formula/harfbuzz#default?
There was a problem hiding this comment.
Those shouldn't be exposed into HOMEBREW_PREFIX/lib as they are C# dependencies only intended for GCM to see.
Based on upstream tarball and .deb, GCM should be able to find those from within its installed path. If it can't, then should be an upstream bug.
EDIT: In case unaware, all files in tarball are installed into Caskroom (brew --caskroom git-credential-manager). What binary does is create a symlink from there, but the real file is still in Caskroom along with shared libraries.
There was a problem hiding this comment.
Ah, I get what you mean. That makes it much cleaner, and indeed just works. I'll commit these changes
readefries
force-pushed
the
feat/add-linux-support-to-cask
branch
from
b30eef0 to
a50fac3
Compare
readefries
force-pushed
the
feat/add-linux-support-to-cask
branch
2 times, most recently
from
de8fcc7 to
1e092a1
Compare
Signed-off-by: Hendrik Bruinsma <hbruinsma@xs4some.nl>
readefries
force-pushed
the
feat/add-linux-support-to-cask
branch
from
1e092a1 to
b9f5806
Compare
5 participants
After making any changes to a cask, existing or new, verify:
brew audit --cask --online <cask>is error-free.brew style --fix <cask>reports no offenses.Additionally, if adding a new cask:
brew audit --cask --new <cask>worked successfully.HOMEBREW_NO_INSTALL_FROM_API=1 brew install --cask <cask>worked successfully.brew uninstall --cask <cask>worked successfully.zapstanza paths.I added references to Linux binaries for both x64 and arm64. Validated the install on my devcontainer with the Homebrew image, and verified that the installation and working of the binary was successful. I used it to verify my ideas with existing casks and help craft the changes.