feat(server): add request-level logging via TraceLayer#895
Open
sjenning wants to merge 1 commit intoNVIDIA:mainfrom
Open
feat(server): add request-level logging via TraceLayer#895sjenning wants to merge 1 commit intoNVIDIA:mainfrom
sjenning wants to merge 1 commit intoNVIDIA:mainfrom
Conversation
Wrap gRPC and HTTP services with TraceLayer to log method, path, status, and latency for every request. Health/readiness probe endpoints are logged at debug level to reduce noise.
|
All contributors have signed the DCO ✍️ ✅ |
Author
|
I have read the DCO document and I hereby sign the DCO. |
Author
|
recheck |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
tower_http::trace::TraceLayerto gRPC and HTTP services in the gateway multiplexer to log method, path, HTTP status, and latency for every request/health,/healthz,/readyz) are logged at debug level to reduce noisetower-httpwith thetracefeature was already in the workspaceFixes #892
Related Issue
#892
Changes
crates/openshell-server/src/multiplex.rs: Wrap both inner services withTraceLayerinMultiplexService::serve(), addmake_request_spanandlog_responsehelper functionsTesting
cargo check -p openshell-serverpassescargo test -p openshell-server— all 8 tests pass (unit + integration)Checklist