feat(server): serve health endpoints on separate unauthenticated port#903
Merged
TaylorMutch merged 1 commit intoNVIDIA:mainfrom Apr 21, 2026
Merged
Conversation
Move /health, /healthz, and /readyz to a dedicated plaintext HTTP port (default 8081) so Kubernetes probes work without mTLS client certificates. - Add health_bind_address to Config with --health-port CLI arg - Spawn standalone axum::serve for health_router on the health port - Remove health routes from the main multiplexed HTTP router - Update Helm statefulset probes from tcpSocket to httpGet on health port - Fix cluster-healthcheck.sh to open/close TCP without sending data, avoiding InvalidContentType TLS errors in the gateway log
TaylorMutch
reviewed
Apr 21, 2026
Collaborator
TaylorMutch
left a comment
TaylorMutch
left a comment
There was a problem hiding this comment.
Couple of optional nits
TaylorMutch
approved these changes
Apr 21, 2026
Collaborator
|
recheck |
Collaborator
|
Tested locally and confirmed this all works - Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Move
/health,/healthz, and/readyzto a dedicated plaintext HTTP port (default 8081) so Kubernetes probes work without mTLS client certificates. Also fixes the Docker cluster healthcheck to avoid sending plaintext bytes into the TLS listener.Related Issue
Fixes #897
Changes
health_bind_addresstoConfigwith--health-portCLI arg (default 8081, envOPENSHELL_HEALTH_PORT)axum::serveforhealth_routeron the health port (plain HTTP, no TLS)--portvs--health-port)healthcontainer port, switch all probes fromtcpSockettohttpGeton health portcluster-healthcheck.shto open/close TCP without sending data, avoidingInvalidContentTypeTLS errorsTesting
cargo check -p openshell-core -p openshell-serverpassescargo test -p openshell-core -p openshell-server --libpasses (223 tests)cluster-healthcheck.shas source of remaining TLS errorsmise run e2e)Checklist