Skip to content
Open
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 8 additions & 6 deletions conversions/binary_to_decimal.py
Original file line number Diff line number Diff line change
@@ -1,6 +1,6 @@
def bin_to_decimal(bin_string: str) -> int:
"""
Convert a binary value to its decimal equivalent
Convert a binary value to its decimal equivalent.

>>> bin_to_decimal("101")
5
Expand All @@ -24,17 +24,19 @@ def bin_to_decimal(bin_string: str) -> int:
ValueError: Non-binary value was passed to the function
"""
bin_string = str(bin_string).strip()

if not bin_string:
raise ValueError("Empty string was passed to the function")

is_negative = bin_string[0] == "-"
if is_negative:
bin_string = bin_string[1:]
if not all(char in "01" for char in bin_string):

if not bin_string or not all(char in "01" for char in bin_string):
raise ValueError("Non-binary value was passed to the function")
decimal_number = 0
for char in bin_string:
decimal_number = 2 * decimal_number + int(char)
return -decimal_number if is_negative else decimal_number

result = int(bin_string, 2)
return -result if is_negative else result


if __name__ == "__main__":
Expand Down