Conversation
| builder.Append(Message); | ||
| } | ||
|
|
||
| public Context With(object key, object value) |
There was a problem hiding this comment.
I think this naming is a bit too vague. If I didn't have the context of a diff to see what it's replacing, I wouldn't be able to figure out what it's supposed to do. I propose naming it something like WithTag or WithLabel.
There was a problem hiding this comment.
How does WithInfo for key value pairs, and WithTag for single points of data sound?
| } | ||
| } | ||
|
|
||
| private void WatchForSingleton() |
There was a problem hiding this comment.
What happens here if someone changes scenes and creates a new NetworkManager rather than reusing the previous one (like, say, if they're switching from a lobby to an instanced game so they're changing to a new session)? Or if multiple NetworkManagers exist at once as in our tests?
There was a problem hiding this comment.
I also listen to the NetworkManager.OnDestroy. If the singleton manager is destroyed, it will set the internal manager to null and then re-subscribe to the NetworkManager.OnSingletonReady to wait for a new one to come in.
2 participants
Purpose of this PR
ContextualLoggerclass that can hold references to aNetworkManagerand a GameObjectILogContextinterface to standardize how LogContexts can be written to a builderContextstruct that is passed to the functions on theContextualLoggerto collect information about specific callsitesNetworkManager,NetworkManagerHelper, andNetworkManagerEditor.ContextualLoggerJira ticket
Changelog
Documentation
Testing & QA (How your changes can be verified during release Playtest)
Functional Testing
Manual testing :
Manual testing doneAutomated tests:
Covered by existing automated testsCovered by new automated testsDoes the change require QA team to:
Review automated tests?Execute manual tests?Provide feedback about the PR?If any boxes above are checked the QA team will be automatically added as a PR reviewer.
Backports