Conversation
Guard `set_result(False)` in `_process_platform_messages` with a `done()` check so a disconnect after a successful connect no longer tries to re-resolve the already-resolved `_connected_to_platform_websocket` future. This preserves the original `ConnectionClosedError` in logs instead of masking it with `InvalidStateError`. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
vdusek
added
adhoc
github-actions
Bot
added
the
tested
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #867 +/- ##
=======================================
Coverage 86.64% 86.64%
=======================================
Files 48 48
Lines 2920 2920
=======================================
Hits 2530 2530
Misses 390 390
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Pijukatel
approved these changes
Apr 20, 2026
…ession The test previously only asserted that the task did not raise `InvalidStateError`, which is trivially satisfied if the disconnect path was never taken. Inspect `caplog` to confirm a `ConnectionClosedError` was actually logged by `_process_platform_messages`, so the regression scenario is genuinely exercised. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Guard
set_result(False)inApifyEventManager._process_platform_messageswith adone()check. Previously, a websocket disconnect after a successful connect would try to re-resolve the already-resolved_connected_to_platform_websocketfuture, raisingInvalidStateErrorand masking the originalConnectionClosedErrorin logs.Adds a regression test that forces a mid-stream abnormal close from the server and asserts the background task does not surface
InvalidStateError.