[codegen] annotate call/method-call/ternary with class/interface result types#665
Closed
[codegen] annotate call/method-call/ternary with class/interface result types#665
Conversation
Contributor
Benchmark Results (Linux x86-64)
CLI Tool Benchmarks
|
…lt types (#658 steps 5-7)
Owner
Author
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Before
`foo()`, `obj.m()`, and `a ? b : c` expressions weren't cached in typeOf even when their result type was a concrete class/interface.
After
All three kinds are cached when the resolved result type is class/interface.
Description
Bundled steps 5-7 of #658 into one PR since they share the mechanical pattern (delegate to `resolveExpressionTypeRich`, filter by same class/interface source-kind as steps 1-4). With this, all seven candidate kinds from the audit are wired:
Verification
Refs #658.