Skip to content

Update Delphi.gitignore#4840

Open
chuacw wants to merge 1 commit intogithub:mainfrom
chuacw:master
Open

Update Delphi.gitignore#4840
chuacw wants to merge 1 commit intogithub:mainfrom
chuacw:master

Conversation

@chuacw
Copy link
Copy Markdown

@chuacw chuacw commented Apr 10, 2026

Added RAD Studio 13.1 WinARM64EC directory and DUnitX results

Added RAD Studio 13.1 WinARM64EC directory and DUnitX results
@chuacw chuacw requested a review from a team as a code owner April 10, 2026 06:16
Copy link
Copy Markdown
Collaborator

@dooleydevin dooleydevin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One request before this is ready 👍

Comment thread Delphi.gitignore
Comment on lines +32 to +40
Win32/
Win64/
OSX64/
OSXARM64/
Android/
Android64/
iOSDevice64/
Linux64/
WinARM64EC/
Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add the comments back to the start of these lines, or provide a justification for why you are removing them?

Copy link
Copy Markdown
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Most of the time, files are generated in these directories, that should not be placed in a repo.
So, if files were generated in these directories, the default of having comments at the start of these lines would cause the files to be added to GitHub.
So, removing the comments would prevent this situation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants