Skip to content

feat: declare workflow_call secrets explicitly#2

Merged
vklimontovich merged 1 commit intomainfrom
feat/explicit-secrets
Apr 20, 2026
Merged

feat: declare workflow_call secrets explicitly#2
vklimontovich merged 1 commit intomainfrom
feat/explicit-secrets

Conversation

@vklimontovich
Copy link
Copy Markdown
Contributor

Adds explicit secrets: declaration to on.workflow_call so callers can pass
specific secrets instead of relying on secrets: inherit.

Declares:

  • OPENAI_API_KEY (required)
  • AI_CODE_REVIEW_APP_ID (optional)
  • AI_CODE_REVIEW_PRIVATE_KEY (optional)

After merging, dispatch the release.yml workflow to generate a new tag.

@vklimontovich
Copy link
Copy Markdown
Contributor Author

Looks good

@vklimontovich vklimontovich merged commit 616968c into main Apr 20, 2026
1 check passed
Copy link
Copy Markdown

@jitsu-code-review jitsu-code-review Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good. Declaring secrets here aligns the reusable-workflow contract with how this workflow already consumes and optional app credentials, and I don’t see correctness or security regressions in this change.

Copy link
Copy Markdown

@jitsu-code-review jitsu-code-review Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No additional concerns found after full diff validation. The new workflow_call secrets declaration is consistent with current secret usage and improves reusable-workflow correctness.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant