feat: add keyboard event support to SearchBar#1425
Open
AasthathecoderX wants to merge 5 commits intolayer5io:masterfrom
Open
feat: add keyboard event support to SearchBar#1425AasthathecoderX wants to merge 5 commits intolayer5io:masterfrom
AasthathecoderX wants to merge 5 commits intolayer5io:masterfrom
Conversation
Signed-off-by: AasthathecoderX <bhat.aasthaa@gmail.com>
Contributor
Author
|
The below are the videos showing the working:: enter_working.mp4Tab_working.mp4up_downworking.mp4spacebar_working.mp4 |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request introduces an onKeyDown prop to the SearchBar and StyledSearchBar components, enabling custom keyboard event handling and search execution via the 'Enter' key. Feedback focuses on enhancing the handleKeyDown logic to respect event.defaultPrevented, cleaning up redundant comments, and fixing indentation inconsistencies to maintain code quality.
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Rajesh Nagarajan <139469505+Rajesh-Nagarajan-11@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: Rajesh Nagarajan <139469505+Rajesh-Nagarajan-11@users.noreply.github.com>
Co-authored-by: gemini-code-assist[bot] <176961590+gemini-code-assist[bot]@users.noreply.github.com> Signed-off-by: AasthathecoderX <bhat.aasthaa@gmail.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Notes for Reviewers
This PR fixes #718
Signed commits