.NET: Support returning durable workflow results from HTTP trigger endpoint#5321
.NET: Support returning durable workflow results from HTTP trigger endpoint#5321
Conversation
There was a problem hiding this comment.
Pull request overview
Adds an opt-in “wait for completion” mode to the Azure Functions HTTP workflow trigger so callers can synchronously receive workflow results (plain text by default, JSON when Accept: application/json is provided), along with docs, samples, and an integration test update.
Changes:
- Add
x-ms-wait-for-responsesupport for workflow HTTP trigger and refactor shared header parsing helpers. - Add synchronous completion wait path that returns
200 OKwith either plain text or structured JSON (runId,status,result). - Update samples/docs and add an end-to-end integration test for the new header behavior.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 5 comments.
Show a summary per file
| File | Description |
|---|---|
| dotnet/src/Microsoft.Agents.AI.Hosting.AzureFunctions/BuiltInFunctions.cs | Implements wait-for-completion HTTP response path and consolidates header parsing helpers. |
| dotnet/tests/Microsoft.Agents.AI.Hosting.AzureFunctions.IntegrationTests/WorkflowSamplesValidation.cs | Adds an integration test covering the wait-for-response header for workflows. |
| dotnet/src/Microsoft.Agents.AI.Hosting.AzureFunctions/CHANGELOG.md | Adds an Unreleased changelog entry for the new HTTP trigger behavior. |
| dotnet/samples/04-hosting/DurableWorkflows/AzureFunctions/01_SequentialWorkflow/demo.http | Adds request examples demonstrating wait-for-response (plain text + JSON). |
| dotnet/samples/04-hosting/DurableWorkflows/AzureFunctions/01_SequentialWorkflow/README.md | Documents how to wait for workflow results and request JSON responses. |
| if (metadata is null) | ||
| { | ||
| return await CreateErrorResponseAsync(req, context, HttpStatusCode.InternalServerError, | ||
| $"Workflow orchestration '{instanceId}' returned no metadata.", acceptsJson); |
There was a problem hiding this comment.
It's also possible that no orchestration with this ID exists.
| if (metadata.RuntimeStatus is OrchestrationRuntimeStatus.Failed) | ||
| { | ||
| string errorMessage = metadata.FailureDetails?.ErrorMessage ?? "Unknown error"; | ||
| return await CreateErrorResponseAsync(req, context, HttpStatusCode.InternalServerError, |
There was a problem hiding this comment.
Is InternalServerError the right status code for us to use on a failed workflow? I wonder if an HTTP 200 response is actually more appropriate from an HTP protocol perspective. HTTP 500 typically means that we failed to process the request due to some internal failure, but in this case, the operation succeeded, but the state of the workflow happens to be that it failed.
| /// <param name="Result">The workflow result as a JSON element so POCOs serialize as nested objects rather than escaped strings.</param> | ||
| private sealed record WorkflowRunSuccessResponse( | ||
| [property: JsonPropertyName("runId")] string RunId, | ||
| [property: JsonPropertyName("status")] string Status, |
There was a problem hiding this comment.
There's an inconsistency here with AgentRunSuccessResponse, which returns the status as an integer value rather than a string value. The string value probably makes more sense, but to resolve this inconsistency, consider using a different property name, like WorkflowStatus, to avoid confusion.
Summary
Adds support for synchronously returning workflow execution results from the HTTP trigger endpoint. By default, the workflow HTTP endpoint fires-and-forgets (202 Accepted). With this change, callers can set the
x-ms-wait-for-response: trueheader to wait for the workflow to complete and receive the result directly in the HTTP response (200 OK). Results are returned as plain text by default, or as a structured JSON object whenAccept: application/jsonis specified.Changes
New feature
x-ms-wait-for-responseheader inRunWorkflowOrchestrationHttpTriggerAsyncWaitForWorkflowCompletionAsyncmethod that callsWaitForInstanceCompletionAsyncand handles failure/completed/unexpected statusesAccept: application/jsonheader to return a structured JSON response (runId,status,result)JsonElement) rather than double-encoded stringsCode quality improvements
WaitForResponseHeaderNameconstant (replaces two inline string literals)ShouldWaitForResponse(req, defaultValue)helper to eliminate duplicated header-parsing logic across workflow and agent triggersAcceptsJson(req)helper to deduplicateAcceptheader checks across 4 response methodsacceptsJsonparameter toCreateErrorResponseAsyncto avoid redundant header reads withinWaitForWorkflowCompletionAsyncDocs & samples
01_SequentialWorkflow/README.mdwith curl/PowerShell examples for the new headerTests
WorkflowSamplesValidation.csverifying the header works end-to-endJSON response examples
Plain text (default):
JSON (with
Accept: application/json):{ "runId": "abc123def456", "status": "Completed", "result": "Cancellation email sent for order 12345 to jerry@example.com." }JSON with POCO result (executor returns an object):
{ "runId": "abc123def456", "status": "Completed", "result": { "orderId": 123, "email": "jerry@example.com" } }Description
Contribution Checklist