Conversation
baywet
left a comment
There was a problem hiding this comment.
Thanks for the contribution!
I double checked and the other big consumer of this package is also using a bundler
https://github.com/OfficeDev/microsoft-365-agents-toolkit/blob/c0eb0bed661202bfd85b3bb1bd61e21b0b73c0b4/packages/fx-core/package.json#L87
|
@baywet I left two points unresolved. Also could you please trigger CI? |
done. Another aspect of cjs I forgot to mention earlier is jest's configuration that'll need to be updated. |
|
@deinok sorry, I had kind of forgotten about this one until #7528 started failing. Would you mind having a look at this failure please? https://github.com/microsoft/kiota/actions/runs/22797694626/job/66295106427?pr=7441 |
@baywet Getting clean ESM + CommonJS outputs without introducing bundling has been messy, so I went with this approach:
lib/foldertsconfig.jsonto includelib/instead of excluding everything elseThe VSCode plugin should still work fine with ESM because it’s bundled with webpack, so webpack will bundle what it needs from the ESM module and tree-shake unused exports where possible.