tools: add non-default OpenSSL versions to the test-shared workflow#62862
Open
panva wants to merge 5 commits intonodejs:mainfrom
Open
tools: add non-default OpenSSL versions to the test-shared workflow#62862panva wants to merge 5 commits intonodejs:mainfrom
panva wants to merge 5 commits intonodejs:mainfrom
Conversation
Signed-off-by: Filip Skokan <panva.ip@gmail.com>
Collaborator
|
Review requested:
|
nodejs-github-bot
added
meta
panva
added
commit-queue-squash
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Adds an additional OpenSSL shared-libraries matrix to
test-shared.ymlso PRs run against the supported OpenSSL releases we don't already build against by default. No more waiting for a full CI to find out a crypto/TLS change is broken on another version 🙏.collect-openssl-versionsdynamically builds the matrix from the pinned nixpkgs and https://endoflife.date, dropping EOL versions (but keeping ones that have extended support) and the version the existingbuildjob already covers.SUPPORTED_OPENSSL_VERSIONenv run withcontinue-on-error: trueso that OpenSSL versions we haven't adjusted for yet don't fail GHA.First commit for simple review, second is refactoring to a composite action, rest is applying feedback.