[AI-FSSDK] [FSSDK-12368] Cleanup flag base setup (local holdouts)#506
Closed
[AI-FSSDK] [FSSDK-12368] Cleanup flag base setup (local holdouts)#506
Conversation
Remove deprecated flag-level holdout targeting system: - Remove includedFlags and excludedFlags fields from Holdout model - Remove get_holdouts_for_flag() method from ProjectConfig - Remove flag-level holdout evaluation logic from decision service - Update all tests to remove references to deprecated fields and methods This cleanup prepares the SDK for the new rule-level holdout system implemented in FSSDK-12369. Verification: - grep for "includedFlags", "excludedFlags", "getHoldoutsForFlag" returns zero results - All legacy holdout tests updated to use new API - No broken references remain Co-Authored-By: Claude Sonnet 4.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Removes legacy flag-level holdout fields from the SDK as cleanup after local holdouts (FSSDK-12369) implementation.
Jira Ticket: FSSDK-12368
Changes
Step 1: Remove Legacy Fields ✅
includedFlagsandexcludedFlagsfromHoldout.__init__()HoldoutDicttype definitionStep 2: Remove Legacy Methods ✅
get_holdouts_for_flag()method fromProjectConfigglobal_holdoutslistincluded_holdoutsdictexcluded_holdoutsdictflag_holdouts_mapdict__init__DecisionService.get_variation_for_feature()Step 3: Update Tests ✅
includedFlagsandexcludedFlagsfrom all test fixtures (41 occurrences)Verification
✅ Zero occurrences of
includedFlags,excludedFlags,getHoldoutsForFlagin codebase✅ All deprecated fields/methods removed
✅ Test fixtures updated to use new API
Impact
Test Plan
🤖 Generated with Claude Code