feat(DataViewTextFilter): use chipTitle prop for filter chip category#633
Open
raswonders wants to merge 1 commit intopatternfly:mainfrom
Open
feat(DataViewTextFilter): use chipTitle prop for filter chip category#633raswonders wants to merge 1 commit intopatternfly:mainfrom
raswonders wants to merge 1 commit intopatternfly:mainfrom
Conversation
AssistedBy: Cursor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hey!
in our codebase we are sometimes in need to use different chip title than the title used in dropdown menu. This could be due to various reasons, sometimes dropdown title is just to wordy and takes too much space, other times its for compatibility with our previous solution.
What it does:
It introduces additional optional prop
chipTitlewhich allows passing different name for chip than its used in filter dropdown.Compatibility
Change is backward compatible when this new prop is omitted component behaves as before.
would you find this useful? Also If you'd agree I can patch other filter types as well.
Thanks!