Refactor: Extract replaceIdentifierReferences and remove reliance on this in ASTCallbacks#8728
Open
LalitNarayanYadav wants to merge 1 commit intoprocessing:dev-2.0from
Conversation
… from ASTCallbacks
Contributor
Author
|
This is the first incremental refactor PR for #8694. I’ve focused on extracting The goal is to make the code easier to reason about and prepare for further cleanup in smaller, reviewable steps. Next steps (planned incremental PRs):
Happy to adjust the approach based on feedback before proceeding further. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Addresses #8694
Changes:
replaceIdentifierReferencesfromASTCallbacksinto a standalone helper functionthisbinding withinASTCallbacksthis.replaceIdentifierReferences(...)calls with direct function callsBinaryExpression,AssignmentExpression) to use explicitASTCallbacksreferencesASTCallbacksThis improves modularity and makes the code easier to reason about, while preserving existing behavior.
Screenshots of the change:
N/A (non-visual refactor)
PR Checklist
npm run lintpasses