Fix docs build with sphinx 'extensions' config key#2352
Open
Yann-P wants to merge 1 commit intopydata:mainfrom
Open
Fix docs build with sphinx 'extensions' config key#2352Yann-P wants to merge 1 commit intopydata:mainfrom
Yann-P wants to merge 1 commit intopydata:mainfrom
Conversation
Regression introduced by 469e908. extensions=["pydata_sphinx_theme"] config makes sphinx call setup() in __init__, before self.builder is defined. https://github.com/sphinx-doc/sphinx/blob/master/sphinx/application.py#L299 https://github.com/sphinx-doc/sphinx/blob/master/sphinx/application.py#L334
Carreau
approved these changes
Apr 20, 2026
Collaborator
Carreau
left a comment
Carreau
left a comment
There was a problem hiding this comment.
Looks good to me,
Should we emit a warning when we encounter this case; or is there something the users should do ?
Collaborator
|
And I'm not even sure if we can or should send a PR to sphinx to make sure that the types annotation can reflect this might be missing (or at least have it always define but be |
drammock
approved these changes
Apr 20, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #2349
Regression introduced by 469e908, which adds a call to
get_theme_options_dict, which readsself.builder, butself.builderis not yet defined if theextensionssphinx config is used.https://github.com/sphinx-doc/sphinx/blob/cc7c6f435ad37bb12264f8118c8461b230e6830c/sphinx/application.py#L299
https://github.com/sphinx-doc/sphinx/blob/cc7c6f435ad37bb12264f8118c8461b230e6830c/sphinx/application.py#L334