Open
Conversation
This is a straightforward merging of the two loops, leaving room for follow-ups. One exception: skipping logic now uses the "wasm" tag for all builders; previously PR builders used "wasi". These tags currently always appear together. Co-Authored-By: Zachary Ware <zach@python.org>
zware
approved these changes
Apr 21, 2026
| buildername = name + " " + branch.name | ||
| source = Git(repourl=GIT_URL, branch=branch.git_branch, **GIT_KWDS) | ||
|
|
||
| if branch.is_pr: |
Member
There was a problem hiding this comment.
IIUC, this branch is not actually necessary; GitHub should work just as well as Git for the regular builds. Your comment about leaving room for cleanup certainly applies here, though :)
|
|
||
| # disable notifications for unstable & PR builders | ||
| # (all these lists are the same now, but we might need to | ||
| # diverge gain later.) |
Member
There was a problem hiding this comment.
Pre-existing nit:
Suggested change
| # diverge gain later.) | |
| # diverge again later.) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a straightforward merging of the two loops; it leaves room for follow-ups.
One exception: skipping logic now uses the "wasm" tag for all builders; previously PR builders used "wasi". These tags currently always appear together.
I'm sending PRs with individual changes from @zware's branch, to review/test/fixup/revert the changes one by one. This is based on 45b7b4a.