gh-148801: Fix unbound C recursion in Element.__deepcopy__()#148802
Open
StanFromIreland wants to merge 2 commits intopython:mainfrom
Open
gh-148801: Fix unbound C recursion in Element.__deepcopy__()#148802StanFromIreland wants to merge 2 commits intopython:mainfrom
Element.__deepcopy__()#148802StanFromIreland wants to merge 2 commits intopython:mainfrom
Conversation
serhiy-storchaka
approved these changes
Apr 21, 2026
Member
serhiy-storchaka
left a comment
serhiy-storchaka
left a comment
There was a problem hiding this comment.
LGTM. 👍
I have a style suggestion which you can accept or ignore.
| tag = deepcopy(st, self->tag, memo); | ||
| if (!tag) | ||
| if (!tag) { | ||
| _Py_LeaveRecursiveCall(); |
Member
There was a problem hiding this comment.
These three _Py_LeaveRecursiveCalls can be replaced with goto error (you need also to initialize element with NULL and use Py_XDECREF). Larger diff, but three less lines in the result.
The current style is good too.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
_elementtree.Element.__deepcopy__causes causes stack overflow #148801