-
Notifications
You must be signed in to change notification settings - Fork 293
Clarify positional argument handling in TypedDict constructor #2248
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
BHUVANSH855
wants to merge
9
commits into
python:main
Choose a base branch
from
BHUVANSH855:typeddict-positional-args
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+27
−1
Open
Changes from all commits
Commits
Show all changes
9 commits
Select commit
Hold shift + click to select a range
3544832
Clarify positional argument handling in TypedDict constructor and add…
BHUVANSH855 1bf0e61
Merge branch 'main' into typeddict-positional-args
BHUVANSH855 ebe4ee9
Merge branch 'main' into typeddict-positional-args
BHUVANSH855 6f1a05d
Merge branch 'main' into typeddict-positional-args
BHUVANSH855 103a1f3
Merge branch 'main' into typeddict-positional-args
BHUVANSH855 75c4011
Update typeddict.rst
BHUVANSH855 6708ec2
Merge branch 'main' into typeddict-positional-args
BHUVANSH855 a6d7eab
Merge branch 'main' into typeddict-positional-args
BHUVANSH855 6352969
Relax TypedDict constructor spec and conformance tests for positional…
BHUVANSH855 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -0,0 +1,18 @@ | ||
| from typing import TypedDict | ||
|
|
||
| class TD1(TypedDict): | ||
| a: int | ||
|
|
||
| class TD2(TD1): | ||
| b: str | ||
|
|
||
| # keyword arguments (OK) | ||
| TD1(a=1) | ||
|
|
||
| # positional TypedDict (OK) | ||
| td2: TD2 = {"a": 1, "b": "x"} | ||
| TD1(td2) | ||
|
|
||
| # additional positional forms (behavior may vary across type checkers) | ||
| TD1({"a": 1}) | ||
| TD1([("a", 1)]) |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the feedback! @carljm
I initially added wording to clarify that type checkers may accept additional positional forms, but based on the discussion, I’ve simplified the spec to avoid implying specific behavior beyond what is clearly supported.
For now, the spec only describes the keyword-based constructor and the case of a single TypedDict positional argument, without constraining or explicitly encouraging other forms.
Happy to refine this further if we reach consensus on specific patterns that should be required.