fix(settings): hide data-retention nav item when user lacks enterprise plan#4256
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub. |
PR SummaryLow Risk Overview Reviewed by Cursor Bugbot for commit 3728d2b. Configure here. |
Greptile SummaryThis PR removes Confidence Score: 5/5Safe to merge — single-line config fix with no logic changes or side effects. The change is minimal, correct, and aligns Data Retention's visibility with every other enterprise nav item. No logic, API, or data-flow changes are involved. No files require special attention. Important Files Changed
Flowchart%%{init: {'theme': 'neutral'}}%%
flowchart TD
A[Render settings sidebar] --> B{requiresEnterprise?}
B -- No --> C[Always show item]
B -- Yes --> D{showWhenLocked?}
D -- true --> E[Show with upgrade badge]
D -- false / absent --> F{User has enterprise plan?}
F -- Yes --> G[Show item]
F -- No --> H[Hide item]
subgraph Before this PR
DR_before[data-retention showWhenLocked: true] --> E
end
subgraph After this PR
DR_after[data-retention no showWhenLocked] --> F
end
Reviews (1): Last reviewed commit: "fix(settings): hide data-retention nav i..." | Re-trigger Greptile |
Summary
showWhenLocked: truefrom the Data Retention nav item so it follows the same visibility rules as all other enterprise features (SSO, Whitelabeling, Audit Logs, Access Control)Type of Change
Testing
Tested manually
Checklist