Skip to content

E2E: trial for more workers#7343

Draft
phyllis-sy-wu wants to merge 1 commit intopsyw-0414-E2E-parallel-workersfrom
psyw-0417-E2E-try-more-workers
Draft

E2E: trial for more workers#7343
phyllis-sy-wu wants to merge 1 commit intopsyw-0414-E2E-parallel-workersfrom
psyw-0417-E2E-try-more-workers

Conversation

@phyllis-sy-wu
Copy link
Copy Markdown
Contributor

@phyllis-sy-wu phyllis-sy-wu commented Apr 17, 2026

WHY are these changes introduced?

Evaluate whether increasing E2E parallel workers from 5 (#7309) to 10 improves CI run time enough to justify the added resource pressure on our 4 vCPU CI runners.

WHAT is this pull request doing?

Bumps E2E worker count to 10 for benchmarking against the 5-worker baseline in #7309.

Benchmark Results:
(under stable conditions, very few teardown failures or flaky retries)

5 workers (#7309) 10 workers (#7343) Savings
Local 8.8 min 6.3 min 2.5 min (28%)
CI 11m 43s 8m 49s 2m 54s (25%)

Conclusion: Sticking with 5 workers. ~3 min CI savings is nice but not worth the tradeoff:

  • More parallel store creation/teardown = more surface area for flaky cleanup
  • 4 vCPU CI runner is already tight with 5 workers; 10 doubles contention
  • Once teardown is more robust, bumping workers is a one-line config change

CI runner specs: ubuntu-latest = 4 vCPUs, 16 GB RAM (GitHub docs).

How to test your changes?

Compare CI run times between this PR and #7309.

Post-release steps

N/A — trial branch, not intended to merge.

Checklist

  • I've considered possible cross-platform impacts (Mac, Linux, Windows)
  • I've considered possible documentation changes
  • I've considered analytics changes to measure impact
  • The change is user-facing, so I've added a changelog entry with pnpm changeset add

Copy link
Copy Markdown
Contributor Author

phyllis-sy-wu commented Apr 17, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more

This stack of pull requests is managed by Graphite. Learn more about stacking.

@github-actions
Copy link
Copy Markdown
Contributor

Differences in type declarations

We detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:

  • Some seemingly private modules might be re-exported through public modules.
  • If the branch is behind main you might see odd diffs, rebase main into this branch.

New type declarations

We found no new type declarations in this PR

Existing type declarations

packages/cli-kit/dist/public/node/upgrade.d.ts
@@ -1,5 +1,3 @@
-import { getAutoUpgradeEnabled, setAutoUpgradeEnabled } from '../../private/node/conf-store.js';
-export { getAutoUpgradeEnabled, setAutoUpgradeEnabled };
 /**
  * Utility function for generating an install command for the user to run
  * to install an updated version of Shopify CLI.

@phyllis-sy-wu phyllis-sy-wu mentioned this pull request Apr 20, 2026
4 tasks
@phyllis-sy-wu phyllis-sy-wu changed the title Trial branch for more workers E2E: trial for more workers Apr 20, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant