E2E: trial for shards#7349
Draft
phyllis-sy-wu wants to merge 1 commit intopsyw-0414-E2E-parallel-workersfrom
Draft
E2E: trial for shards#7349phyllis-sy-wu wants to merge 1 commit intopsyw-0414-E2E-parallel-workersfrom
phyllis-sy-wu wants to merge 1 commit intopsyw-0414-E2E-parallel-workersfrom
Conversation
This was referenced Apr 20, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
4 tasks
Contributor
Differences in type declarationsWe detected differences in the type declarations generated by Typescript for this branch compared to the baseline ('main' branch). Please, review them to ensure they are backward-compatible. Here are some important things to keep in mind:
New type declarationsWe found no new type declarations in this PR Existing type declarationspackages/cli-kit/dist/public/node/upgrade.d.ts@@ -1,5 +1,3 @@
-import { getAutoUpgradeEnabled, setAutoUpgradeEnabled } from '../../private/node/conf-store.js';
-export { getAutoUpgradeEnabled, setAutoUpgradeEnabled };
/**
* Utility function for generating an install command for the user to run
* to install an updated version of Shopify CLI.
|
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
WHY are these changes introduced?
Evaluate whether sharding E2E tests across 2 CI machines (as suggested by @gonzaloriestra in #7309) improves wall-clock time compared to running all tests on a single machine.
Currently E2E tests run on a single
ubuntu-latestrunner (4 vCPUs, 16 GB RAM — GitHub docs). With 2 shards, each machine runs ~half the test files with 5 workers each.WHAT is this pull request doing?
Adds a matrix strategy with
shard: ['1/2', '2/2']to the E2E CI job, passing--shardto Playwright. Each shard uploads artifacts with unique names to avoid collisions.Benchmark Results:
(under stable conditions, very few teardown failures or flaky retries)
7m 41s (shard 2/2)
How to test your changes?
Compare CI run times between this PR, #7309 (5 workers baseline), and #7343 (10 workers).
Post-release steps
N/A — trial branch, not intended to merge.
Checklist
pnpm changeset add